chore: refactor live conection parameters into separate vertex and mldef functions. #1790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
copybara/835355573
branch
4 times, most recently
from
0bdcfea to
8ee000c
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
copybara/835355573
branch
from
8ee000c to
ec3cdaa
Compare
…def functions. chore: move the credentials refresh into asyncio.to_thread (this func is async, requests should be too) The diff looks messy, but this really just splits the contents of the giant if/else in connect into _prepare_connection_vertex and _prepare_connection_mldev. No behavior changes expected. Existing tests pass, additional tests added for coverage. PiperOrigin-RevId: 835355573
copybara-service
bot
force-pushed
the
copybara/835355573
branch
from
ec3cdaa to
26e74d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: refactor live conection parameters into separate vertex and mldef functions.
chore: move the credentials refresh into asyncio.to_thread (this func is async, requests should be too)
The diff looks messy, but this really just splits the contents of the giant if/else in connect into _prepare_connection_vertex and _prepare_connection_mldev.
No behavior changes expected. Existing tests pass, additional tests added for coverage.